Skip to content

[rebranch][cxx-interop] fix MSVC testcase check line for indirect return #76373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

[rebranch][cxx-interop] fix MSVC testcase check line for indirect return #76373

merged 1 commit into from
Sep 11, 2024

Conversation

@hyp
Copy link
Contributor

@hyp hyp commented Sep 10, 2024

No description provided.

@hyp hyp requested a review from compnerd September 10, 2024 16:37
@hyp
Copy link
Contributor Author

hyp commented Sep 10, 2024

@swift-ci please test

compnerd
compnerd approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we might even be able to put this into main right?

@hjyamauchi hjyamauchi mentioned this pull request Sep 10, 2024
Merged
@hyp
Copy link
Contributor Author

hyp commented Sep 10, 2024

yeah I think so, I can double check if this also works on main too locally

egorzhdan
egorzhdan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyp hyp merged commit fb160f6 into rebranch Sep 11, 2024
@hyp hyp deleted the hyp/rebranch-fix-indirect-return-msvc-case branch September 11, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

@egorzhdan egorzhdan egorzhdan approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hyp @compnerd @egorzhdan