Skip to content

Fixup omitting frame pointers on various compilers and architectures #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2017
Merged

Fixup omitting frame pointers on various compilers and architectures #7626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3e18e3
Omit leaf frame pointers on i686 architectures
hughbe Feb 20, 2017
dea1412
Use the correct flags to omit leaf frame pointers with clang-cl and MSVC
hughbe Feb 20, 2017
0191dde
Don't omit leaf frame pointers on 64 bit architectures
hughbe Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cmake/modules/AddSwift.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,13 @@ function(_add_variant_c_compile_flags)
if(optimized OR CFLAGS_FORCE_BUILD_OPTIMIZED)
list(APPEND result "-O2")

# Add -momit-leaf-frame-pointer on x86.
if("${CFLAGS_ARCH}" STREQUAL "i386" OR "${CFLAGS_ARCH}" STREQUAL "x86_64")
list(APPEND result "-momit-leaf-frame-pointer")
# Omit leaf frame pointers on x86.
if("${CFLAGS_ARCH}" STREQUAL "i386" OR "${CFLAGS_ARCH}" STREQUAL "i686")
if(NOT SWIFT_COMPILER_IS_MSVC_LIKE)
list(APPEND result "-momit-leaf-frame-pointer")
else()
list(APPEND result "/Oy")
endif()
endif()
else()
list(APPEND result "-O0")
Expand Down