[cxx-interop] Disambiguate template instantiations with SIMD parameters #76249
Conversation
egorzhdan
requested review from
beccadax,
hyp,
ian-twilightcoder and
zoecarver
as code owners
|
@swift-ci please smoke test |
There was a problem hiding this comment.
Nit: This is probably not performance critical code, but usually it is more efficient to use llvm::Twine to concat strings, like:
(Twine("foo") + "bar" + "baz").str();
Feel free to leave as is.
There was a problem hiding this comment.
Good catch, switched this to use Twine.
egorzhdan
force-pushed
the
egorzhdan/simd-template-param
branch
from
2d29a2a to
484a5af
Compare
|
@swift-ci please smoke test |
There was a problem hiding this comment.
I think with twine we might no longer need the to_string. But not 100% confident on that.
There was a problem hiding this comment.
It doesn't compile for me if I remove to_string.
There was a problem hiding this comment.
Hmm, maybe it still needs a ctor like Twine("SIMD") + Twine(type->getNumElements()) + ...
There was a problem hiding this comment.
Yeah, I think I slightly prefer to_string over Twine(...) in this case, since that makes it explicit that we aren't e.g. constructing a string with a given capacity/size – something a std::string constructor would do 🙂
When converting a C++ class template instantiation name into Swift, we previously didn't account for possible SIMD types. Those types were printed as `_`. This meant that e.g. `std::vector<simd::float3>` and `std::vector<simd::float4>` would get the same Swift name, causing compiler errors down the road. rdar://134214091
egorzhdan
force-pushed
the
egorzhdan/simd-template-param
branch
from
484a5af to
d19c9eb
Compare
|
@swift-ci please smoke test |
When converting a C++ class template instantiation name into Swift, we previously didn't account for possible SIMD types. Those types were printed as
_. This meant that e.g.std::vector<simd::float3>andstd::vector<simd::float4>would get the same Swift name, causing compiler errors down the road.rdar://134214091