[cxx-interop] Create benchmarks for using std::span in Swift #76245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susmonteiro
commented
Sep 4, 2024
susmonteiro
commented
- swift-ci linux tests do not support std::span
Contributor
Author
|
@swift-ci please benchmark |
Contributor
Author
|
@swift-ci please smoke test |
susmonteiro
requested review from
egorzhdan
and removed request for
eeckstein
egorzhdan
reviewed
Sep 9, 2024
Contributor
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
Looks great, just one minor comment.
* swift-ci linux tests do not support std::span
susmonteiro
force-pushed
the
susmonteiro/cxx-span-benchmarks
branch
from
dab51ea to
6239c10
Compare
Contributor
Author
|
@swift-ci please benchmark |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.