Skip to content

Conversation

@susmonteiro
Copy link
Contributor

@susmonteiro susmonteiro commented Sep 2, 2024

When the benchmarks are built with SwiftPM, the std=c++20 flag is passed if the -cxx-interoperability-mode is present. This patch switches from -Xfrontend -enable-experimental-cxx-interop to the required interoperability flag.

@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro added the c++ interop Feature: Interoperability with C++ label Sep 2, 2024
@susmonteiro susmonteiro changed the title [cxx-interop] pass -std=c++20 to configurations using std::span [cxx-interop] pass -std=c++20 to configurations using std::span Sep 2, 2024
@susmonteiro susmonteiro marked this pull request as ready for review September 2, 2024 14:24
@susmonteiro susmonteiro marked this pull request as draft September 2, 2024 14:44
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from 4ea1132 to b65546f Compare September 2, 2024 14:51
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from b65546f to 62df055 Compare September 2, 2024 17:51
When the benchmarks are built with SwiftPM, the -std=c++20 flag is passed if the -cxx-interoperability-mode is present. This patch switches from -Xfrontend -enable-experimental-cxx-interop to the required interoperability flag.
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from 62df055 to 282b1ba Compare September 2, 2024 17:53
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro merged commit c7e33f1 into main Sep 3, 2024
@susmonteiro susmonteiro deleted the susmonteiro/cxx-span-benchmarks branch September 3, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ interop Feature: Interoperability with C++

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants