[build-script] Always clean 'SwiftTesting' and 'SwiftTestingMacros' #76179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These products are built with CMake. In incremental build environments, these products don't detect compiler changes, so the artifacts aren't rebuilt unless the source code of these projects are changed. To workaround that, always clean them in build-script to ensure they are rebuilt. rdar://135021207
rintaro
force-pushed
the
cmake-clean-testing-rdar135021207
branch
from
fe11e03 to
89e9622
Compare
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Sep 4, 2024
etcwilde
reviewed
Sep 4, 2024
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
would be good to have an option to not do a clean build every time, but otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These products are built with CMake. In incremental build environments, these products don't detect compiler changes, so the artifacts aren't rebuilt unless the source code of these projects are changed. To workaround that, always clean them in build-script to ensure they are rebuilt.
rdar://135021207