[6.0] build-script: Copy libclang_rt.a from the host toolchain for visionOS
#76176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
added
🍒 release cherry pick
During the toolchain build, when building the Swift standard library for platforms other than macOS the `libclang_rt.a` needs to be copied out of the host SDK. That wasn't happening for visionOS. Resolves rdar://135023111.
tshortli
force-pushed
the
availability-visionos-6.0
branch
from
d374f6a to
ab290f6
Compare
tshortli
changed the title
#if os check in Availability.swift.libclang_rt.a from the host toolchain for visionOS
Contributor
Author
|
@swift-ci please build toolchain macOS platform |
Contributor
Author
|
@swift-ci please test |
shahmishal
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@backDeployedthunks #76140 landed. It turns out that the toolchain build has not been copyinglibclang_rt.aout of the host SDK for visionOS builds, which did not matter until the stdlib began using__isPlatformVersionAtLeast, which comes fromlibclang_rt. Also, an#if osconditional in [6.0] SILOptimizer: Allow inlining of transparent functions in@backDeployedthunks #76140 was incorrectly specified.libclang_rt.afrom the host toolchain for visionOS #76177