Skip to content

IRGen: Fix two typed throws bugs in IRGenThunk #76129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 29, 2024
Merged

IRGen: Fix two typed throws bugs in IRGenThunk #76129

merged 3 commits into from
Aug 29, 2024

Conversation

@aschwaighofer
Copy link
Contributor

@aschwaighofer aschwaighofer commented Aug 28, 2024

  • We need to map the direct type error explosion back to the native result in IRGenThunk
  • Add missing case in IRGenThunk when we pass typed errors directly

rdar://134730970

@aschwaighofer
Copy link
Contributor Author

aschwaighofer commented Aug 29, 2024

@swift-ci test

@aschwaighofer aschwaighofer merged commit dd0de58 into swiftlang:main Aug 29, 2024
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Sep 12, 2024
@aschwaighofer
Revert "Merge pull request swiftlang#76129 from aschwaighofer/irgen_t…
66586a6 
…yped_throws_irgenthunk"

This reverts commit dd0de58, reversing
changes made to 74b3221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aschwaighofer