Revert "Use SwiftIfConfig to determine where to emit new parser diagnostics #76040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostics" This reverts commit 1da2631.
DougGregor
requested review from
CodaFi,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Member
Author
|
@swift-ci please smoke test |
This was referenced Aug 22, 2024
Member
Author
|
A better fix is swiftlang/swift-syntax#2816, but I'm testing both now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1da2631.
This commit uncovered a bug in the new Swift parser's handling of
@_specialize. Revert it while we fix that