Sema: Look through missing imports during type lookup #75746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve knock-on diagnostics, resolve unqualified types to their matching member type declarations regardless of whether an import is missing when the `MemberImportVisibility` features is enabled. Part of rdar://126637855.
If an `ExtendedNominalRequest`'s initial type lookup yields no results, query again ignoring missing imports to find nominals that were excluded due to the `MemberImportVisibility` feature being enabled. The missing import will be diagnosed during type resolution and allowing the request to succeed enables better diagnostics. Part of rdar://126637855.
To improve knock-on diagnostics, resolve qualified types to their matching member type declarations regardless of whether an import is missing when the `MemberImportVisibility` features is enabled. Part of rdar://126637855.
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci please smoke test |
xymus
approved these changes
Aug 7, 2024
tshortli
deleted the
member-import-visibility-import-accurate-access-levels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking up type declarations with the
MemberImportVisiblityfeature enabled, resolve both qualified and unqualified types to their matching member type declarations regardless of whether an import is missing. This improves the quality of knock-on diagnostics and allows accurate access levels to be suggested in the fix-its for the missing imports.Part of rdar://126637855.