[cxx-interop] Fix reverse interop crash when using raw modules #75714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
reviewed
Aug 6, 2024
Contributor
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just one small comment.
Some fields in the AST are cached values that are populated lazily. We should not use those values directly as in case they are not yet computed we get back null pointers. Use ASTContext instead which can call the slow path if the cache is not yet populated. rdar://132746445
Xazax-hun
force-pushed
the
gaborh/raw-module-crash
branch
from
f935855 to
0276d46
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Aug 6, 2024
Xazax-hun
added a commit
that referenced
this pull request
Sep 3, 2024
Explanation: A low-level clang API was used that relies on a cached value being present. This fix is changing that API call to another that calculates the value if the cache is not yet populated. Scope: C++ reverse interop. Risk: Low, replacing an API call with a different that has the same semantics (other than calculating the value when the cache is empty). Testing: Regression test added. Issue: rdar://132746445 Reviewer: @egorzhdan Original PR: #75714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields in the AST are cached values that are populated lazily. We should not use those values directly as in case they are not yet computed we get back null pointers. Use ASTContext instead which can call the slow path if the cache is not yet populated.
rdar://132746445