Skip to content

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 30, 2024

… existing pre-built candidate binary module files in the scanner, on a non-caching build.

As-is, this default interferes with the incremental build machinery which conservatively assumes that binary module dependencies must cause dependents to be re-built.
@artemcm artemcm added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels Jul 30, 2024
@artemcm
Copy link
Contributor Author

artemcm commented Jul 30, 2024

@swift-ci test

@artemcm artemcm requested a review from nkcsgexi July 30, 2024 21:34
@artemcm artemcm marked this pull request as ready for review July 30, 2024 21:34
@artemcm artemcm requested a review from a team as a code owner July 30, 2024 21:34
@nkcsgexi
Copy link
Contributor

This PR has fixed a recent incremental build regression. We should take it.

@artemcm artemcm merged commit d454e93 into swiftlang:release/6.0 Jul 31, 2024
@artemcm artemcm deleted the 60DisableScannerValidationNonCachingBuild branch July 31, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants