Skip to content

[cxx-interop] Create benchmarks for using std::span in Swift #75436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

[cxx-interop] Create benchmarks for using std::span in Swift #75436

merged 1 commit into from
Aug 30, 2024

Conversation

@susmonteiro
Copy link
Contributor

No description provided.

@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

3 similar comments
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro susmonteiro changed the title Create benchmarks for using std::span in Swift [cxx-interop] Create benchmarks for using std::span in Swift Jul 25, 2024
@susmonteiro susmonteiro added the c++ interop Feature: Interoperability with C++ label Jul 25, 2024
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch 2 times, most recently from 78eca77 to 11d248f Compare July 25, 2024 11:23
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro susmonteiro marked this pull request as ready for review July 25, 2024 11:24
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

egorzhdan
egorzhdan reviewed Jul 25, 2024
View reviewed changes
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from 11d248f to 06e46a6 Compare July 25, 2024 11:39
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from 06e46a6 to e70d144 Compare July 25, 2024 14:52
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from e70d144 to ab20d99 Compare July 25, 2024 15:12
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from ab20d99 to e6cf8d1 Compare July 29, 2024 14:43
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from e6cf8d1 to 4238b8f Compare August 15, 2024 11:59
egorzhdan
egorzhdan reviewed Aug 15, 2024
View reviewed changes
@susmonteiro susmonteiro requested a review from al45tair as a code owner August 28, 2024 11:27
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from 3177cb9 to 93df78e Compare August 30, 2024 14:11
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

@susmonteiro susmonteiro marked this pull request as ready for review August 30, 2024 15:20
egorzhdan
egorzhdan reviewed Aug 30, 2024
View reviewed changes
@susmonteiro
[cxx-interop] Create benchmarks for using std::span in Swift
796ccb7 
* swift-ci linux tests do not support std::span
@susmonteiro susmonteiro force-pushed the susmonteiro/cxx-span-benchmarks branch from 93df78e to 796ccb7 Compare August 30, 2024 15:40
@susmonteiro
Copy link
Contributor Author

@swift-ci please benchmark

@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

egorzhdan
egorzhdan approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@susmonteiro susmonteiro enabled auto-merge August 30, 2024 15:49
@susmonteiro susmonteiro merged commit 96b14a7 into main Aug 30, 2024
@susmonteiro susmonteiro deleted the susmonteiro/cxx-span-benchmarks branch August 30, 2024 20:09
@tshortli
Copy link
Contributor

I think this PR may have broken the macOS toolchain build, could you take a look?

/Users/ec2-user/jenkins/workspace/swift-PR-toolchain-macos/branch-main/swift/benchmark/utils/CxxTests/CxxStdlibPerformance.h:18:24: error: no template named 'span' in namespace 'std'
16 | using SetOfU32 = std::set<uint32_t>;
17 | #if __has_include(<span>)
18 | using SpanOfU32 = std::span<uint32_t>;
   |                        `- error: no template named 'span' in namespace 'std'
19 | #endif
20 |

https://ci.swift.org/job/swift-PR-toolchain-macos/1474/

@egorzhdan
Copy link
Contributor

Looks like -std=c++20 isn't passed in some configurations.

@kabiroberai kabiroberai mentioned this pull request Sep 2, 2024
Merged
@ahoppen ahoppen mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@eeckstein eeckstein eeckstein approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov

@ktoso ktoso Awaiting requested review from ktoso

@rintaro rintaro Awaiting requested review from rintaro

@hyp hyp Awaiting requested review from hyp

@DougGregor DougGregor Awaiting requested review from DougGregor

@bnbarham bnbarham Awaiting requested review from bnbarham

@CodaFi CodaFi Awaiting requested review from CodaFi

@al45tair al45tair Awaiting requested review from al45tair

@zoecarver zoecarver Awaiting requested review from zoecarver

@hamishknight hamishknight Awaiting requested review from hamishknight

Assignees

No one assigned

Labels

c++ interop Feature: Interoperability with C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@susmonteiro @tshortli @egorzhdan @eeckstein