AST: Add a IgnoreMissingImports option to name lookup
#75158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
beccadax,
egorzhdan,
hborla,
hyp,
ian-twilightcoder,
slavapestov,
xedin and
zoecarver
as code owners
tshortli
force-pushed
the
member-import-visibility-package
branch
from
59ff088 to
15ea21c
Compare
tshortli
force-pushed
the
member-import-visibility-package
branch
from
15ea21c to
32ed20d
Compare
Control enforcement of member import visibility requirements via a new option, instead of piggy-backing on the existing IgnoreAccessControl option. Adopt the option when doing fallback lookups for unviable members so that the compiler can diagnose the reason that a member is inaccessible more reliably. Previously, with MemberImportVisibility enabled decls with the package access level could be mis-diagnosed as inaccessible due to their access level when really they were inaccessible due to a missing import. Resolves rdar://131501862.
tshortli
force-pushed
the
member-import-visibility-package
branch
from
32ed20d to
d002da0
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control enforcement of member import visibility requirements via a new option, instead of piggy-backing on the existing
IgnoreAccessControloption. Adopt the option when doing fallback lookups for unviable members so that the compiler can diagnose the reason that a member is inaccessible more reliably. Previously, withMemberImportVisibilityenabled decls with the package access level could be mis-diagnosed as inaccessible due to their access level when really they were inaccessible due to a missing import.Resolves rdar://131501862.