Skip to content

[6.0🍒] NCGenerics: enforce same-source conformance rule #75142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

[6.0🍒] NCGenerics: enforce same-source conformance rule #75142

merged 1 commit into from
Jul 11, 2024

Conversation

@kavon
Copy link
Member

@kavon kavon commented Jul 10, 2024 •
edited
Loading

  • Explanation: Retroactive conformances to Copyable were being permitted and that's nonsense. SE-427 actually says it has to be defined in the same source file, like Sendable.
  • Scope: Source breaking, but easy to remedy in the legal cases.
  • Issue: rdar://131486561
  • Original PR: NCGenerics: enforce same-source conformance rule #75141
  • Risk: Low
  • Testing: Swift CI.
  • Reviewer: @slavapestov

@kavon
NCGenerics: enforce same-source conformance rule
42677b9 
SE-427 says the conformance to Copyable must appear in the same source
file as the nominal type.

resolves rdar://131486561

(cherry picked from commit 233742a)
@kavon kavon requested a review from a team as a code owner July 10, 2024 21:08
@kavon
Copy link
Member Author

kavon commented Jul 10, 2024

@swift-ci test

@kavon kavon enabled auto-merge July 10, 2024 21:08
@kavon kavon disabled auto-merge July 10, 2024 21:09
@kavon kavon enabled auto-merge July 10, 2024 21:20
@kavon kavon merged commit 705e1c0 into swiftlang:release/6.0 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbkka tbkka tbkka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kavon @tbkka