[Modules] Avoid false swift module sharing #75133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
artemcm
approved these changes
Jul 10, 2024
cachemeifyoucan
force-pushed
the
eng/PR-131408266
branch
from
d3adf17 to
de6d7d1
Compare
cachemeifyoucan
requested review from
DougGregor,
beccadax,
egorzhdan,
hyp,
ian-twilightcoder and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-131408266
branch
from
de6d7d1 to
d7306f5
Compare
Contributor
Author
|
@swift-ci please smoke test |
When the swiftmodule is built with different clang importer arguments, they can have the same module hash, causing them to be wrongly re-used even they contains different interfaces. Add ReducedExtraArgs to the module hash to disambiguate them. However, some Xcc arguments, most commonly `-D` options do not affect the swiftmodule being generated. Do not pass `-Xcc -DARGS` to swift interface compilation to reduce the amount of module variants in the build. rdar://131408266
cachemeifyoucan
force-pushed
the
eng/PR-131408266
branch
from
d7306f5 to
a32dd95
Compare
Contributor
Author
|
@swift-ci please smoke test |
artemcm
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the swiftmodule is built with different clang importer arguments,
they can have the same module hash, causing them to be wrongly re-used even
they contains different interfaces. Add ReducedExtraArgs to the module hash to
disambiguate them.
However, some Xcc arguments, most commonly
-Doptions do not affect theswiftmodule being generated. Do not pass
-Xcc -DARGSto swiftinterface compilation to reduce the amount of module variants in the
build.
rdar://131408266