Simplify and optimize SubstitutionMap #75068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
simplify-sub-map
branch
from
9c67cc4 to
f15fd45
Compare
slavapestov
requested review from
ahoppen,
bnbarham,
eeckstein,
hamishknight,
hborla,
jckarter,
rintaro,
rjmccall,
tshortli and
xedin
as code owners
rjmccall
approved these changes
Jul 9, 2024
There was a bunch of logic to lazily populate replacement types corresponding to reducible generic parameters. This didn't seem to have a clear purpose so let's remove it.
slavapestov
force-pushed
the
simplify-sub-map
branch
from
f15fd45 to
eca5a1c
Compare
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please test |
ahoppen
reviewed
Jul 16, 2024
| // COMPLETE: Begin completions, 2 items | ||
| // COMPLETE-DAG: Decl[StaticMethod]/Super/TypeRelation[Convertible]: foo()[#S#]; name=foo() | ||
| // COMPLETE-DAG: Decl[StaticMethod]/Super/TypeRelation[Convertible]: qux()[#B<S>#]; name=qux() | ||
| // COMPLETE-DAG: Decl[StaticMethod]/Super/Flair[ExprSpecific]/TypeRelation[Convertible]: qux()[#any Q#]; name=qux() |
Member
There was a problem hiding this comment.
This is a regression. Prior to this PR, the qux completion result was reported as returning B<S> (which it is), after this change, we are reporting qux() as returning any Q, which is less specific.
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Aug 2, 2024
…n when doing implicit member lookup on protocol type This fixes the regression introduced in swiftlang#75068 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.