Skip to content

Conversation

@Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Jul 7, 2024

Fix typos in test/IDE

This is one batch of many PRs fixing typos, see the tracking issue.

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a fair few typos 😅. Thanks @Sajjon, just a couple files that need to be reverted, the rest look good!

@bnbarham
Copy link
Contributor

bnbarham commented Jul 8, 2024

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test Linux

@ahoppen
Copy link
Member

ahoppen commented Jul 16, 2024

@swift-ci Please smoke test macOS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the test failure you also need to rename this file to Overlaid.h and correspondingly change OverlayTest.h to import #include <OverlayTest/Overlaid.h> instead of #include <OverlayTest/Overlayed.h>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoppen thank you, I've done so!

@Sajjon
Copy link
Contributor Author

Sajjon commented Aug 8, 2024

@bnbarham @ahoppen @AnthonyLatsis merged main, squashed, applied suggestions. Merge ready I think, if test pass and if it looks good to you?

@ahoppen
Copy link
Member

ahoppen commented Aug 8, 2024

@swift-ci Please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants