Typos: SwiftCompilerSources
#75025
Merged
Typos: SwiftCompilerSources
#75025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
AnthonyLatsis
left a comment
AnthonyLatsis
left a comment
There was a problem hiding this comment.
Just one suggestion, otherwise looks good.
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/AsyncDemotion.swift
Outdated
Show resolved
Hide resolved
AnthonyLatsis
approved these changes
Jul 12, 2024
Collaborator
AnthonyLatsis
left a comment
AnthonyLatsis
left a comment
There was a problem hiding this comment.
Thanks! Please consider squashing post review commits at this stage. Although we can do that by selecting the merge strategy on GitHub when it is appropriate to squash the whole thing, code owners are not always mindful about this.
Contributor
Author
|
@AnthonyLatsis I've update to main branch, solve a merge conflict and squashed into a single commit. So re-review ready! |
eeckstein
approved these changes
Aug 8, 2024
Collaborator
|
@swift-ci please smoke test |
xwu
reviewed
Aug 19, 2024
| /// same outer 'read', because it is impossible to nest a 'modify' access within a 'read'. For 'modify' accesses, | ||
| /// however, the inner scope must be extended for correctness. A 'modify' access can interfere with other 'modify' | ||
| /// accesss in the same scope. We rely on exclusivity diagnostics to report these interferences. For example: | ||
| /// access in the same scope. We rely on exclusivity diagnostics to report these interferences. For example: |
Collaborator
There was a problem hiding this comment.
I think the intended word here would have been "accesses."
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in
SwiftCompilerSourcesThis is one batch of many PRs fixing typos, see the tracking issue.