[Sema] Let protocols define getter requirements for @_staticExclusiveOnly types #74901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
tshortli
reviewed
Jul 2, 2024
tshortli
approved these changes
Jul 2, 2024
Contributor
tshortli
left a comment
tshortli
left a comment
There was a problem hiding this comment.
The logic looks good. Missing clang-format, though.
Contributor
Author
|
@swift-ci please smoke test |
hamishknight
reviewed
Jul 2, 2024
Co-authored-by: Hamish Knight <[email protected]>
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Azoy
added a commit
that referenced
this pull request
Jul 17, 2024
[Sema] Let protocols define getter requirements for @_staticExclusiveOnly types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable requirements in protocols must always be spelled out with
var, so we weren't allowing types likeAtomicto be a protocol requirement even if the protocol only requires a getter. Lets allow protocol contexts to define getter requirements and error if they have a setter.Resolves: rdar://130447812