6.0: [DCE] Insts that define lexical values seem useful #74167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't delete as dead instructions that define lexical values such as `move_value [lexical]`. rdar://129299803
|
@swift-ci please test |
tbkka
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixed DCE not to delete instructions that define lexical values.
Lexical values, such as those corresponding to source-level
lets, cannot be deleted as dead, even when they have no uses. Previously, DCE could delete such values if they had no non-destroy users. Here this is fixed by preventing instructions which introduce lexical values from being deleted.Scope: Bug fix.
Issue: rdar://129299803
Original PR: #74152
Risk: Low.
Testing: Added SIL test case.
Reviewer: Meghana Gupta ( @meg-gupta )