Skip to content

[6.0] [For PackageCMO] Silently drop @_alwaysEmitIntoClient on a package decl inside a non-serialized type. #73875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[6.0] [For PackageCMO] Silently drop @_alwaysEmitIntoClient on a package decl inside a non-serialized type. #73875

wants to merge 1 commit into from

Conversation

elsh
Copy link
Contributor

@elsh elsh commented May 24, 2024 •
edited
Loading

@aschwaighofer @elsh
SIL: Ignore AEIC on package declaration inside declarations without e…
0b26379 
…ffective public access

Quoting Slava:

"The AST-level access is allowed to be 'more public'. I honestly don't
know why, but it's always worked this way and the 'lowered' access
levels must always intersect the access levels of the parents but with
@UIC, @aeic and @inlinable, that means just ignoring those attributes if
some enclosing context is not @UIC"

rdar://128270848
@elsh elsh requested a review from a team as a code owner May 24, 2024 01:10
@elsh elsh added the swift 6.0 label May 24, 2024
@elsh
Copy link
Contributor Author

elsh commented May 24, 2024

@swift-ci test

@elsh elsh requested a review from aschwaighofer May 24, 2024 01:10
@elsh
Copy link
Contributor Author

elsh commented May 30, 2024

Included in #73993

@elsh elsh closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees
No one assigned
Labels
swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsh @aschwaighofer