[6.0 🍒][Dependency Scanning] Specify Source Locations For Missing Module Dependencies #73819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies This change modifies the dependency scanner to keep track of source locations of each encountered 'import' statement, in order to be able to emit diagnostics with source locations if an import failed to resolve. - Keep track of each 'import' statement's source buffer, line number, and column number when adding it. The dependency scanner utilizes separate compilation instances, and therefore separate Source Managers for scanning `import` statements of user sources and textual interfaces of Swift dependencies. Since import resolution may happen in the main scanner compilation instance while the `import` itself was found by an interface-scanning sub-instance, we cannot simply hold on to the import's `SourceLoc`. - Add libSwiftScan API for diagnostics to carry above source locations to clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #73600
Explanation: This change modifies the dependency scanner to keep track of source locations of each encountered
importstatement, in order to be able to emit diagnostics with source locations if an import failed to resolve.importstatements of user sources and textual interfaces of Swift dependencies. Since import resolution may happen in the main scanner compilation instance while theimportitself was found by an interface-scanning sub-instance, we cannot simply hold on to the import'sSourceLoc.Now instead of un-locatable:
we will now get rich diagnostic output:
Risk: Low-Moderate. This only affects projects which use dependency scanning with Explicitly-Built Modules. The added locations are only used when emitting errors on already-failing compilations.
Testing: Automated tests added to the compiler and driver suite.
Reviewed By: @owenv @cachemeifyoucan @nkcsgexi