[ClangImporter] -Xclang -fbuiltin-headers-in-system-modules is being passed when it shouldn't
#73814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g passed when it shouldn't We were accidentally setting `requiresBuiltinHeadersInSystemModules` because the `else` here gets executed for things that are not WASI or Musl. Fix by making it conditional. rdar://128219177
|
@swift-ci Please smoke test |
egorzhdan
approved these changes
May 22, 2024
|
This is a good change, but |
|
It can, but I believe those are all failure cases that we wouldn't expect to see in practice (unlike the target mismatch). |
|
Still makes me nervous, but ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally setting
requiresBuiltinHeadersInSystemModulesbecause theelsehere gets executed for things that are not WASI or Musl. Fix by making it conditional.rdar://128219177