[6.0] FrontendOpts: teach the compiler to accept project name via an argument #73731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the blocklist mechanism supports using project name as a key for specific actions. We usually retrieve that name via other means such as querying env vars, which isn't CAS friendly. Instead, we should pass the ownining project name down to the compiler via a formal compiler argument.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test Windows |
bnbarham
approved these changes
May 20, 2024
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: the blocklist mechanism supports using project-name as a key for specific actions. We usually retrieve that name via other means such as querying env vars, which isn't CAS friendly. Instead, we should pass the owning project name down to the compiler via a formal compiler argument.
Original PR: #73719 and #73752
Risk: Very Low
Reviewer: Allan Shortlidge