[embedded] Provide Unicode data tables for embedded as a static library #73585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
Azoy,
MaxDesiatov,
eeckstein,
phausler,
rauhul and
zoecarver
Azoy
approved these changes
May 13, 2024
kubamracek
force-pushed
the
embedded-string-unicode-tables
branch
from
6e9fd3e to
b06ca64
Compare
kubamracek
force-pushed
the
embedded-string-unicode-tables
branch
from
b06ca64 to
78d19ff
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial String port to embedded (#70446) skipped adding unicode data tables, and attempts to use anything that requires the data tables (e.g. string equality, hashing, splitting, etc.) will fail to link. This PR resolves this by providing a static library with the data tables, and embedded Swift users are expected to (manually) link this library if they want to use string operations that require data tables.
Note that we need to avoid depending on C++ headers because our -none targets don't have an SDK that would have those headers, I replaced usage of
<limits>with<stdint.h>.