Skip to content

Sema: Report references to missing imports from package extensions through typealiases #73498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024

Conversation

xymus
Copy link
Contributor

@xymus xymus commented May 7, 2024

This diagnostic reports when an exported extension uses a typealias for which the underlying type points to a module that's not imported by the local file. This can break a swiftinterface as we print the underlying type instead of the typealias. Let's make sure it's properly reported for package extensions.

@xymus xymus requested review from elsh and tshortli May 7, 2024 22:28
@xymus xymus requested review from hborla, slavapestov and xedin as code owners May 7, 2024 22:28
@xymus
Copy link
Contributor Author

xymus commented May 7, 2024

@swift-ci Please smoke test

@xymus
Copy link
Contributor Author

xymus commented May 8, 2024

@swift-ci Please smoke test

@xymus xymus merged commit d63d6c8 into swiftlang:main May 9, 2024
@xymus xymus deleted the missing-import-package branch May 9, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants