[Platform] Update musl modulemap and improve musl platform support. #73489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to declare separate top-level modules for every header in the musl C library. Note that our set-up here does require some tweaks to musl itself (specifically, the `alltypes.h` header needs some fairly serious massaging to make it module compatible; in particular, we need to pull out every type declaration into its own separate modularized header in `bits/types`). Also update `Platform.swift` a little for more musl support. rdar://123503615
Added the _modules workaround to make the compiler pull in the correct module when someone does `import stdc_assert` (for instance). Fix various niggles. rdar://123503615
|
@swift-ci Please test |
The Darwin headers have a naming convention for these modules; we should match it. rdar://123503615
|
Explanation: This adds the modulemap and header for musl. |
|
@swift-ci Please test |
tbkka
approved these changes
May 7, 2024
|
@swift-ci Please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to declare separate top-level modules for every header in the musl C library. Note that our set-up here does require some tweaks to musl itself (specifically, the
alltypes.hheader needs some fairly serious massaging to make it module compatible; in particular, we need to pull out every type declaration into its own separate modularized header inbits/types).Also update
Platform.swifta little for more musl support.rdar://123503615