Skip to content

Conversation

@al45tair
Copy link
Contributor

@al45tair al45tair commented May 3, 2024

Add some additional SDK variables that let us mark an SDK as supporting static linking, and/or supporting only static linking.

Don't try to build dynamic libraries if the SDK only supports static linking. Also, do build static libraries if the SDK only supports static linking.

rdar://123503009&rdar://123503191

al45tair added 2 commits May 3, 2024 12:13
Add some additional SDK variables that let us mark an SDK as
supporting static linking, and/or supporting *only* static
linking.

rdar://123503009
Don't try to build dynamic libraries if the SDK only supports
static linking.  Also, *do* build static libraries if the SDK
only supports static linking.

rdar://123503191
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 3, 2024
@al45tair al45tair requested a review from a team as a code owner May 3, 2024 11:20
@al45tair
Copy link
Contributor Author

al45tair commented May 3, 2024

Explanation: Adds support to the Swift build system for static linking, and updates the Libdispatch build for static linking support.
Risk: Low. Only affects Linux and WASI.
Original PR: #71837 #71838
Reviewed by: @edymtt
Resolves: rdar://123503009&rdar://123503191
Tests: Breakage here would show up in PR testing and in CI.

@al45tair
Copy link
Contributor Author

al45tair commented May 3, 2024

(Note: #71837 was a separate PR, but #71838 was stacked on it and got merged after it was approved as a whole. So #71837 shows up as merged even though nobody clicked the "Merge" button for it, because the same changeset was in #71838 as well.)

@al45tair
Copy link
Contributor Author

al45tair commented May 3, 2024

@swift-ci Please test

@al45tair al45tair merged commit 5b3b2f2 into swiftlang:release/6.0 May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants