CMake: add option to link Swift content from Darwin toolchain #73255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edymtt
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please build toolchain |
Contributor
Author
|
@swift-ci please test WebAssembly |
compnerd
approved these changes
Apr 25, 2024
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This is rather unfortunate - these dependencies will not be tracked by the build and so the build may not always be entirely correct.
This is needed in specific Apple internal configurations -- as a result of the limited applicability, this option is not exposed through `build-script` on purpose. Addresses rdar://127014753
Contributor
Author
|
Thanks for understanding -- I'm not fond of these changes either, my plan is to remove those once I figure out a better long term solution. |
edymtt
force-pushed
the
edymtt/allow-linking-swift-content-from-darwin-toolchain
branch
from
8a6a934 to
5f545b4
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please build toolchain |
Contributor
Author
|
@swift-ci please test WebAssembly |
al45tair
approved these changes
Apr 26, 2024
Contributor
al45tair
left a comment
al45tair
left a comment
There was a problem hiding this comment.
It's a bit unpleasant, but it lets us make progress fixing things so we hopefully won't need it at some point and can get rid of it again.
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Apr 26, 2024
Additional testing showed that the path I initially choose does not work in all scenarios. Expands on swiftlang#73255 Still addresses rdar://127014753
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Apr 27, 2024
Additional testing showed that the path I initially choose does not work in all scenarios. Expands on swiftlang#73255 Still addresses rdar://127014753 (cherry picked from commit 291065d)
edymtt
added a commit
to edymtt/llvm-project
that referenced
this pull request
Apr 28, 2024
This is a companion to swiftlang/swift#73255, and it's needed in some Apple internal configurations. Addresses rdar://127113448 (cherry picked from commit 842763b)
edymtt
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 29, 2024
…8647) This is a companion to swiftlang/swift#73255, and it's needed in some Apple internal configurations. Addresses rdar://127113448
edymtt
added a commit
to edymtt/llvm-project
that referenced
this pull request
Apr 29, 2024
… toolchain This is a companion to swiftlang/swift#73255, and it's needed in some Apple internal configurations. Addresses rdar://127113448 (cherry picked from commit ead278f)
edymtt
added a commit
to edymtt/llvm-project
that referenced
this pull request
Apr 29, 2024
… toolchain This is a companion to swiftlang/swift#73255, and it's needed in some Apple internal configurations. Addresses rdar://127113448 (cherry picked from commit ead278f)
edymtt
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 30, 2024
… toolchain (#8653) This is a companion to swiftlang/swift#73255, and it's needed in some Apple internal configurations. Addresses rdar://127113448 (cherry picked from commit ead278f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in specific Apple internal configurations -- as a result of the limited applicability, this option is not exposed through
build-scripton purpose.Addresses rdar://127014753