[Sema] Handle package exportability. #73161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
elsh
changed the title
|
@swift-ci smoke test |
|
There are a few failures in e.g. This one may need an update to the error message: Can we also test that we're not allowing package decls in public inlinable code? |
elsh
force-pushed
the
elsh/pkg-export
branch
2 times, most recently
from
ab17a0f to
d9dec1f
Compare
|
@swift-ci smoke test |
This PR treats package access level as exportable, preventing internally imported types from accidentally being declared in package decl signatures. Added package-specific cases to ExportabilityReason and DisallowedOriginKind to track the validity of imported types at use sites with package access scope. Added tests to cover variety of use cases. Resolves rdar://117586046&125050064&124484388&124306642
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
This now affects projects using |
MaxDesiatov
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 3, 2024
) The exportability rules around `package` access level are updated in a way that an `@_spi public` can't be bound to a `package` var, similar to how `@_spi public` can't be bound to a `public` var. For reference, see swiftlang/swift#73161. This PR corrects such use case.
|
@swift-ci smoke test |
nkcsgexi
reviewed
May 3, 2024
| @@ -2324,7 +2324,7 @@ bool VarDecl::isLayoutExposedToClients() const { | |||
| auto nominalAccess = | |||
| parent->getFormalAccessScope(/*useDC=*/nullptr, | |||
| /*treatUsableFromInlineAsPublic=*/true); | |||
| if (!nominalAccess.isPublic()) return false; | |||
| if (!nominalAccess.isPublicOrPackage()) return false; | |||
There was a problem hiding this comment.
nitpick: move return false to a new line for better debuggability.
nkcsgexi
approved these changes
May 3, 2024
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 15, 2024
) - **Explanation**: Cherry-pick swiftlang/swift#73161 to `releases/6.0` so that SwiftPM 6.0 can be built with a `main` Swift development snapshot - **Scope**: Changes access level of a member from `package` to SPI - **Risk**: Very low, just changes the access lavel - **Testing**: n/a - **Issue**: n/a - **Reviewer**: @MaxDesiatov and @bnbarham on #7525
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…iftlang#7525) The exportability rules around `package` access level are updated in a way that an `@_spi public` can't be bound to a `package` var, similar to how `@_spi public` can't be bound to a `public` var. For reference, see swiftlang/swift#73161. This PR corrects such use case.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…iftlang#7525) The exportability rules around `package` access level are updated in a way that an `@_spi public` can't be bound to a `package` var, similar to how `@_spi public` can't be bound to a `public` var. For reference, see swiftlang/swift#73161. This PR corrects such use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR treats package access level as exportable, preventing
internally imported types from accidentally being declared in
package decl signatures.
Added package-specific cases to ExportabilityReason and
DisallowedOriginKind to track the validity of imported types
at use sites with package access scope. Added tests to cover
variety of use cases.
Resolves rdar://117586046&125050064&124484388&124306642