[DebugInfo] Emit declaration by checking both type and SIL func repr #73120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e0e7a08)
Contributor
Author
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e0e7a08)
Explanation: when compiling with LTO enabled, debug info generation needs to emit declarations of functions that are nested in types (methods, initializers, static methods, etc). This patch fixes this condition was too broad, and nesting free functions that were referenced inside types (like lazy initializers) which shouldn't be nested.
Scope: Small.
Issue: rdar://125729500
Original PRs: #72963
Risk: Low, only affects debug info generation of LTO builds.