[6.0🍒] NCGenerics: restrict conditional Copyable reqs #72961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't really make sense for a conditional conformance requirement for `Copyable` to depend on any other requirement other than other `Copyable` conformance requirements. resolves rdar://124967739 (cherry picked from commit 215c4e1)
Sometimes, quotes or an "aka" for a type are not desirable in a diagnostic, such as one describing a Requirement. This modifier suppresses such additional formatting a Type in a diagnostic. (cherry picked from commit 0ce97b8)
Member
Author
|
@swift-ci test |
jckarter
approved these changes
Apr 10, 2024
tbkka
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Implements part of the SE-427 proposal where Copyable cannot depend on conditional requirements for other protocols.
Scope: Technically source-breaking but there aren't any known sources that used this yet.
Issue: rdar://124967739
Original PR: #72820
Risk: Low.
Testing: Tests included.
Reviewer: @slavapestov