6.0: [BitwiseCopyable] Don't infer for noncopyable. #72934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bailout was accidentally removed in swiftlang#72856 when removing a duplicative diagnostic. rdar://126135770
Contributor
Author
|
@swift-ci please test |
tbkka
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Restore an incorrectly removed bailout for BitwiseCopyable inference.
When removing a bespoke diagnostic, the bailout that would occur under the same circumstances that the diagnostic would be emitted was removed. This change restores the bailout.
Scope: Affects BitwiseCopyable checking.
Issue: rdar://126135770
Original PR: #72929
Risk: Very low.
Testing: Added a test case.
Reviewer: Kavon Farvardin ( @kavon )