[Demangler] Further optimizations for the remangler. #72902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace use of `snprintf()` with some custom code (this is around 10x faster on my machine). Move a few of the `Node` member functions to the header so they're inlined. Optimize the `deepEquals()` function by adding an `isSimilarTo()` method on `Node`; the checks that were happening in the `deepEquals()` function could be implemented more efficiently by making use of details of the internal representation of `Node`. rdar://125739630
Ignore the line and column number in the output. rdar://125989715
Contributor
Author
|
Explanation: These are needed to help offset the effects of the prespecialized metadata support, which has put the remangler into a performance critical path it wasn't previously in. |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test macOS platform |
tbkka
approved these changes
Apr 8, 2024
Contributor
Author
|
@swift-ci Please test macOS platform |
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of
snprintf()with some custom code (this is around 10x faster on my machine).Move a few of the
Nodemember functions to the header so they're inlined.Optimize the
deepEquals()function by adding anisSimilarTo()method onNode; the checks that were happening in thedeepEquals()function could be implemented more efficiently by making use of details of the internal representation ofNode.rdar://125739630