[6.0] Revert "[TypeChecker] TypeChecker::isSubtypeOf should recognize Sendable/@Sendable subtyping" #72877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Apr 5, 2024
kalebers
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #72868
This approach for ambiguity resolution regressed existing ternary expressions
that join to
any Sendableand one branch is inferred from the ternary type variable.The test-cases introduced by the original PR I left in place with error messages and
TODOs to figure out a way to resolve ambiguity.
Scope: Ranking solutions where the same type variable gets Sendable and non-Sendable type assignments i.e. ternary expressions where branches are Sendable but contextual type isn't and vice versa.
Main Branch PRs: Revert "[TypeChecker]
TypeChecker::isSubtypeOfshould recognize Sendable/@Sendable subtyping" #72868Risk: Very Low
Reviewed By: @hborla
Testing: Added test-cases to the test suite.