Fix two problems with opaque return types -vs- parameter packs #72847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fix-rdar123645784
branch
from
79e719c to
f17e066
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
fix-rdar123645784
branch
from
f17e066 to
482f2dd
Compare
The names of the private witness table accessor thunks we generate for an opaque return type mangle the concrete conformance of the underlying type. If a conformance requirement of the opaque return type was witnessed by a conditional conformance of a variadic generic type, we would crash because of an unimplemented case in the mangler. Fixes rdar://problem/125668798.
…ePackExpansionLevel Fixes rdar://problem/123645784.
Unfortunately SILGen still blows up when emitting witness thunks here.
slavapestov
force-pushed
the
fix-rdar123645784
branch
from
482f2dd to
6d3229a
Compare
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix infinite recursion in opaque type substitution when parameter packs are present
Opaque type replacement is not semantically a transformation that maps parameter packs to concrete packs, so we must pass
SubstFlags::PreservePackExpansionLevel. Otherwise we would get an infinite recursion in SIL type substitution.Fixes rdar://123645784.
Fix crash when opaque return type witnessed by variadic generic type with conditional conformance
There was a missing case in the mangler.
Fixes rdar://125668798.