[6.0] update PrintAsObjC compatibility symbols test to work with condensed clang symbol graphs #72838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QuietMisdreavus
commented
Apr 4, 2024
QuietMisdreavus
commented
- Explanation: Updates a test to handle a change in behavior in Clang ExtractAPI where it stops pretty-printing symbol graph JSON by default.
- Scope: Test-only change.
- Issue: None
- Original PR: update PrintAsObjC compatibility symbols test to work with condensed clang symbol graphs #72837
- Risk: Very low. This is a test-only change that makes it more resilient to Clang updates.
- Testing: Automated testing passes at desk.
- Reviewer: @daniel-grumberg
|
Please test with following pull request: @swift-ci Please test |
QuietMisdreavus
changed the title
airspeedswift
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.