[6.0] Fix LifetimeDependenceDefUseWalker for address yields. #72768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
force-pushed
the
60-fix-address-yield
branch
from
a39bdc7 to
5459504
Compare
Contributor
Author
|
@swift-ci test |
atrick
force-pushed
the
60-fix-address-yield
branch
from
5459504 to
387730f
Compare
atrick
force-pushed
the
60-fix-address-yield
branch
from
387730f to
cec8cf7
Compare
Contributor
Author
|
@swift-ci test |
These core utils did not handle UnconditionalCheckedCastAddrInst or UncheckedRefCastAddrInst correctly. (cherry picked from commit a1bb9f4)
It is not a SingleValueInstruction. (cherry picked from commit 66dcf6a)
(cherry picked from commit 6fcec2f)
Do not treat address yields as escapes. Fixes rdar://125752476 (`UnsafeRawPointer` property in non-escapable type doesn't compile) (cherry picked from commit 1b6be74)
atrick
force-pushed
the
60-fix-address-yield
branch
from
cec8cf7 to
0954b1b
Compare
Contributor
Author
|
@swift-ci test |
meg-gupta
approved these changes
Apr 9, 2024
tbkka
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not treat address yields as escapes.
--- CCC ---
Explanation: Fix LifetimeDependenceDefUseWalker for address yields.
Scope: Allows NonescapableTypes to be used with _modify accessors.
Radar/SR Issues: rdar://125752476 (UnsafeRawPointer property in non-escapable type doesn't compile)
Original PR: #72764
Risk: This fixes a latent bug in SIL utilities and verification. It reduces risk overall.
Testing: Unit tests added
Reviewer: TBD