Use the BorrowingSwitch implementation for all noncopyable switches.
#72577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please test macOS |
…um_data`. Under OSSA, the instruction may still be structurally responsible for consuming its operand even if the result is dead, so we can't remove it without breaking invariants. More generally, this should probably apply to any instruction which consumes one or more of its operands, has no side effects, and doesn't produce any nontrivial results that require further consumption to keep the value alive. I went with this targeted fix, since it addresses a problem that shows up in practice (rdar://125381446) and the more general change appears to disturb the optimizer pipeline while building the standard library.
It works well enough now that it should be an acceptable replacement for both borrowing and consuming switches that works in more correct situations than the previous implementation. This does however expose a few known issues that I'll try to fix in follow ups: - overconsumes cause verifier errors instead of raising diagnostics (rdar://125381446) - cases with multiple pattern labels aren't yet supported (rdar://125188955) - copyable types with the `borrowing` or `consuming` modifiers should probably use noncopyable pattern matching. The `BorrowingSwitch` flag is still necessary to enable the surface-level syntax changes (switches without `consume` and the `_borrowing` modifier, for instance).
jckarter
force-pushed
the
enable-borrowing-switch-backend
branch
from
a9bfca5 to
5ad2603
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works well enough now that it should be an acceptable replacement for both borrowing and consuming switches that works in more correct situations than the previous implementation. This does however expose a few known issues that I'll try to fix in follow ups:
borrowingorconsumingmodifiers should probably use noncopyable pattern matching.The
BorrowingSwitchflag is still necessary to enable the surface-level syntax changes (switches withoutconsumeand the_borrowingmodifier, for instance).rdar://126209276