[Stdlib][Build] Fix the standard library build for fully static Linux. #71848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
requested review from
a team,
artemcm,
egorzhdan,
hyp,
mikeash and
zoecarver
as code owners
|
This sits on top of #71847. |
al45tair
force-pushed
the
eng/PR-123508245
branch
from
a8cc685 to
8f4a746
Compare
|
It's just this one changeset that needs reviewing here. The other changes come from upstream PRs that are being reviewed by others and that have already been updated, so please don't waste time looking at those. |
etcwilde
reviewed
May 3, 2024
Use the new `SWIFT_SDK_<sdk>_STATIC_LINKING_SUPPORTED` and `_STATIC_ONLY` flags instead of hardcoding support for Linux and WASI. Also, use the `_LIB_SUBDIR` variable rather than lowercasing the SDK. rdar://123504757
This is really just about setting appropriate defaults (such as making sure that the static Linux triple causes us to use lld). rdar://123506306
We only need this for WASI and Glibc. rdar://123506306
The backtracer and its build system need a couple of changes to make them work with the new fully-static Linux support. rdar://123507656
Mostly this just means adding `Musl` as a module dependency of various things and making sure that we build things for `swift_static` even if `SWIFT_BUILD_STATIC_STDLIB` isn't enabled. There's also a slight difference in the declaration of `memcmp()`; musl's declaration is more like the one we have on Darwin. rdar://123508245
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly this just means adding
Muslas a module dependency of various things and making sure that we build things forswift_staticeven ifSWIFT_BUILD_STATIC_STDLIBisn't enabled.There's also a slight difference in the declaration of
memcmp(); musl's declaration is more like the one we have on Darwin.rdar://123508245