Skip to content

Eytzingerize word break data #71731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2024
Merged

Eytzingerize word break data #71731

merged 2 commits into from
Feb 21, 2024

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Feb 19, 2024 •
edited
Loading

Fixes rdar://123278973

@Catfish-Man Catfish-Man self-assigned this Feb 19, 2024
@Catfish-Man
Copy link
Contributor Author

@swift-ci Please Apple Silicon benchmark

@Catfish-Man Catfish-Man force-pushed the ancient-austrian-technology-2 branch from 1abbaee to 59f1af8 Compare February 19, 2024 22:12
@Catfish-Man
Copy link
Contributor Author

@swift-ci Please Apple Silicon benchmark

@Catfish-Man Catfish-Man force-pushed the ancient-austrian-technology-2 branch from 59f1af8 to e9492e9 Compare February 19, 2024 22:49
@Catfish-Man
Copy link
Contributor Author

@swift-ci Please Apple Silicon benchmark

Azoy
Azoy approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I doubt the benchmarks will come up with anything useful because this is only exercised in the regex work.

@Catfish-Man Catfish-Man force-pushed the ancient-austrian-technology-2 branch from e9492e9 to ecc6360 Compare February 20, 2024 01:11
@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man Catfish-Man marked this pull request as ready for review February 20, 2024 01:14
@Catfish-Man Catfish-Man requested a review from a team as a code owner February 20, 2024 01:14
@Catfish-Man
Copy link
Contributor Author

Results from the new benchmark on my machine:

Before:

  # TEST               SAMPLES      MIN   MEDIAN      MAX
 992 StringIterateWords         1 17802.638 17802.638 17802.638

After:

  # TEST               SAMPLES      MIN   MEDIAN      MAX
 992 StringIterateWords         1 5473.480 5473.480 5473.480

@Catfish-Man Catfish-Man enabled auto-merge (squash) February 20, 2024 02:13
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

Build failure should be fixed by swiftlang/swift-package-manager#7350

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test macOS platform

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test macOS platform

@Catfish-Man Catfish-Man merged commit f1feba0 into swiftlang:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azoy Azoy Azoy approved these changes

Assignees

@Catfish-Man Catfish-Man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Catfish-Man @Azoy