[Dependency Scanning] Only omit Clang VFS overlays from Swift dependencies if unused by their Clang dependencies #71691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
DepScanSmartVFSOpt
branch
from
183271d to
d013a02
Compare
Contributor
Author
|
@swift-ci test |
artemcm
requested review from
Bigcheese,
cachemeifyoucan,
nkcsgexi,
tshortli and
xymus
artemcm
changed the title
artemcm
force-pushed
the
DepScanSmartVFSOpt
branch
from
d013a02 to
ce8f7b3
Compare
Contributor
Author
|
@swift-ci smoke test |
artemcm
force-pushed
the
DepScanSmartVFSOpt
branch
from
ce8f7b3 to
75babdb
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
LGTM with a small improvement suggestion in line.
I had an idea of fixing this problem completely long term by:
- switch clang importer to use direct cc1 only: #71118
- do a dependency scanning for clang importer for each swift invocation and use the returning cc1 arg to construct clang importer
Then any optimization can be done in clang scanner, swift will get it for free.
I had a prototype for clang importer dep scanning too. I just need to find it somewhere.
…ncies if unused by Clang dependencies We previously blanket omitted `-Xcc -vfsoverlay` flags from Swift module dependencies' command-line recipes. This is incorrect as the Swift module must have an exact matching VFS overlay that its Clang dependencies use, in order to load said Clang dependnecies successfully and resolve their headers as expected and as was done during the scan. Resolves rdar://122667530
artemcm
force-pushed
the
DepScanSmartVFSOpt
branch
from
75babdb to
500d2e5
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
I think this sounds very promising! I assume we would do this faux-scan after we actually resolved all the Clang dependencies so that it is as near to free as possible? Would be cool to get the benefit of all the command-line optimization work Clang is doing "for free". |
cachemeifyoucan
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously blanket omitted
-Xcc -vfsoverlayflags from Swift module dependencies' command-line recipes. This is incorrect as the Swift module must have an exact matching VFS overlay that its Clang dependencies use, in order to load said Clang dependnecies successfully and resolve their headers as expected and as was done during the scan.Resolves rdar://122667530