Skip to content

[BitwiseCopyable] Verify only within module. #71491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Don't verify lowering in modules built from swiftinterface (which may not have been built with -enable-experimental-feature BitwiseCopyable)

Allow trivial types defined in other modules to lack conformance because those modules may not have been built with the feature enabled.

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci Please Build Toolchain macOS Platform

@nate-chandler
Copy link
Contributor Author

Non-Darwin test failures are from the edited test file now needing // REQUIRES: objc_interop.

Don't verify lowering in modules built from swiftinterface (which may
not have been built with `-enable-experimental-feature BitwiseCopyable`)

Allow trivial types defined in other modules to lack conformance because
those modules may not have been built with the feature enabled.
@nate-chandler nate-chandler force-pushed the bitwise-copyable/within-module branch from 40b1fd7 to 6f3bb49 Compare February 9, 2024 15:02
@nate-chandler
Copy link
Contributor Author

Toolchain built at https://ci.swift.org/job/swift-PR-toolchain-macos/1081/ .

@nate-chandler nate-chandler marked this pull request as ready for review February 9, 2024 15:02
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

@nate-chandler nate-chandler merged commit b935996 into swiftlang:main Feb 9, 2024
@nate-chandler nate-chandler deleted the bitwise-copyable/within-module branch February 9, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant