[CS] Unify ReturnStmt handling #71272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
xedin,
ahoppen,
bnbarham,
rintaro and
slavapestov
as code owners
xedin
reviewed
Jan 31, 2024
xedin
approved these changes
Jan 31, 2024
hamishknight
force-pushed
the
cleanup-return
branch
2 times, most recently
from
83b2053 to
0da6c25
Compare
|
Source compat run passed except for an issue that looks unrelated |
This wasn't consistently used, and consequently could result in some expressions getting their parents invalidated. Instead, replace it with a query to make sure we don't try and add an expression we've already computed the parent info for.
Unify the implementation between single-expression and multi-statement closures. Because we're now storing a contextual type for single expression closure returns, update a code completion test to bring its behavior inline with the multi-statement case.
hamishknight
force-pushed
the
cleanup-return
branch
from
0da6c25 to
deaf2dd
Compare
|
@swift-ci please test |
ahoppen
reviewed
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify the implementation between single-expression and multi-statement closures. Because we're now storing a contextual type for single expression closure returns, update a code completion test to bring its behavior inline with the multi-statement case.