[Test] Make sure macros are enabled for the tests that use the new #isolation macro #71202
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rauhul, please run the CI here. |
|
@swift-ci test |
|
Ping @rintaro, maybe you can review this tiny pull? |
|
Ping @bnbarham, tiny pull that needs review. |
bnbarham
approved these changes
Feb 8, 2024
|
Understood, you can just rip out all these swift-syntax checks then, if this mode will no longer be supported then. In the meantime, this keeps the Android CI green. You can go ahead and merge, as this passes CI. |
|
@MaxDesiatov, can you merge? |
Yep, that's the plan! (and sorry, I forgot to merge after the approval) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #71011, which also checked that macros were enabled before including this new macro in the stdlib. These tests currently fail on the community Android CI, which doesn't have a prebuilt Swift compiler so macros are disabled.
@DougGregor, please review.