[SILGen] In emitDynamicPackLoop, branch to the loop latch only if there's a valid insertion point.
#71096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's a valid insertion point.
simanerush
force-pushed
the
pack-iteration-sil-fix
branch
from
670b82b to
0beffe7
Compare
Member
Author
|
@swift-ci please clean smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
break/continue/returnstatements directly in the loop body cause the control flow to create a branch exiting the body, there would be no valid insertion point for the loop latch branch. Thus, do not create it in such cases.The
break/continuetest case was using these statements inside theifstatement, so this bug did not manifest.Resolves #71074.