[5.10] SimplifyBuiltin: fix simplification of is_same_metatype with dynamic_self types #70683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…self types Dynamic self types are not the same as non-dynamic self types. Fixes a miscompile with dynamic self type comparisons. rdar://119943508
Contributor
Author
|
@swift-ci test |
jckarter
approved these changes
Jan 3, 2024
tbkka
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a miscompile with dynamic self type comparisons. When optimizing metatype comparisons, the optimization has to check if both sides of the comparison are dynamic or not dynamic metatypes.
Issue: rdar://119943508
Risk: Very low. The fix is a small change which makes the optimization more conservative.
Reviewer: @jckarter
Main branch PR: SimplifyBuiltin: fix simplification of is_same_metatype with dynamic_self types #70585