Fix openType() handling of parameter packs #70457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
parameter-pack-open-type
branch
from
4f29c8a to
b028b44
Compare
slavapestov
force-pushed
the
parameter-pack-open-type
branch
from
b028b44 to
0fdf07c
Compare
Fixes: - rdar://112785081 - swiftlang#67906 - swiftlang#68160
Some of these are minor regressions; they will be fixed on main but not release/5.10.
slavapestov
force-pushed
the
parameter-pack-open-type
branch
from
0fdf07c to
bc7044e
Compare
Contributor
Author
|
@swift-ci Please smoke test |
xedin
approved these changes
Jan 9, 2024
Contributor
Author
|
@swift-ci Please smoke test Linux |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test Linux |
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://112785081, rdar://117444028, rdar://119635751, rdar://119635403, fixes #67906, fixes #68160, fixes #68369, fixes #67984.
I will restore the diagnostics in a follow-up PR, and the new ones aren't that much worse.