[region-isolation] Loosen handling around fields that are safe to access concurrently. #69933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess concurrently. Specifically: 1. Classes. We allow for access to Sendable let fields. 2. Structs. We allow for access to Sendable let/var fields. 3. Tuples. We allow for access to Sendable let/var fields. I am going to finish enums in a subsequent PR since I found that I need to mark a bunch more instructions as look through to get that to work (e.x.: load/load_borrow need to be viewed as a cast from address -> object so that we can emit errors on the uses of the load instead of the load itself). These are more invasive so I want to do it a little later. rdar://115124361
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
We are going to do post-commit review on this as well. I am doing this since I am hoping to get this into a toolchain for people to try over the holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
I am going to finish enums in a subsequent PR since I found that I need to mark a bunch more instructions as look through to get that to work (e.x.: load/load_borrow need to be viewed as a cast from address -> object so that we can emit errors on the uses of the load instead of the load itself). These are more invasive so I want to do it a little later.
rdar://115124361